Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest to CI pipeline #198

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add pytest to CI pipeline #198

merged 1 commit into from
Sep 30, 2024

Conversation

Mark2000
Copy link
Contributor

@Mark2000 Mark2000 commented Sep 23, 2024 •
edited
Loading

Description

Closes #81

Adds GitHub action support for pytest.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Tests are now run remotely.

Future Work

Update documentation to build ipynb remotely instead of caching them. Probably leave caching option in some cases? See #200 .

Also, the python 3.9 test is not required and fails due to #170

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I changed an example ipynb, I have locally rebuilt the documentation

@Mark2000 Mark2000 changed the title test test pytest runner Sep 23, 2024
@Mark2000 Mark2000 force-pushed the feature/pytest-runner branch 2 times, most recently from ed0f609 to 66881a3 Compare September 30, 2024 16:51
@Mark2000 Mark2000 force-pushed the feature/pytest-runner branch from 66881a3 to a23f237 Compare September 30, 2024 17:04
@Mark2000 Mark2000 changed the title test pytest runner Add pytest to CI pipeline Sep 30, 2024
LorenzzoQM
LorenzzoQM approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@LorenzzoQM LorenzzoQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Mark2000 Mark2000 merged commit cfa970e into develop Sep 30, 2024
5 of 6 checks passed
@Mark2000 Mark2000 deleted the feature/pytest-runner branch September 30, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorenzzoQM LorenzzoQM LorenzzoQM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run pytest with dockerized Basilisk
2 participants
@Mark2000 @LorenzzoQM