Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis error message for AUTH command #518

Merged
merged 1 commit into from
Nov 22, 2023
+4 −1
Merged

Fix Redis error message for AUTH command #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Hide Redis password in error message
@sebaciv
sebaciv committed Nov 22, 2023
commit 11e8247698fc9f91cdbc654d6f866c44c4fb93fa
5 changes: 4 additions & 1 deletion redis/src/main/scala/com/avsystem/commons/redis/commands/connection.scala
View file
Original file line number Diff line number Diff line change
@@ -50,6 +50,10 @@ trait ConnectionConnectionApi extends NodeConnectionApi {

private final class Auth(username: Opt[String], password: String) extends RedisUnitCommand with ConnectionCommand {
val encoded: Encoded = encoder("AUTH").optAdd(username).add(password).result

// hide password value in error messages
override def toString: String =
s""""AUTH" ${username.mapOr("", u => s""""$u" """)}"<password>""""
}

private object Quit extends RedisUnitCommand with ConnectionCommand {
@@ -60,4 +64,3 @@ trait ConnectionConnectionApi extends NodeConnectionApi {
val encoded: Encoded = encoder("SELECT").add(index).result
}
}