Skip to content

Commit

Permalink
Merge pull request #190 from lawncegoh/master
Browse files Browse the repository at this point in the history
Edited gradle to change jar file to FinSec.jar
  • Loading branch information
lawncegoh authored Oct 22, 2019
2 parents 1a55ed9 + 82f2a8e commit 493acee
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ dependencies {


shadowJar {
archiveName = 'addressbook.jar'
archiveName = 'FinSec.jar'

destinationDir = file("${buildDir}/jar/")
}
Expand Down
6 changes: 5 additions & 1 deletion docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,6 @@ command is entered.
.Execution sequence of the `check 1` command
image::CheckSequenceDiagram.png[width="800"]

==== Why was it implemented this way?
1) The only parameter after the `check` command in the user input is passed into the LogicManager::execute method of the LogicManager instance. +

2) The LogicManager::execute method calls FinSecParser::parseCommand which receives the user input as a parameter. +
Expand Down Expand Up @@ -617,6 +616,11 @@ will then be passed as parameter to the `ModelManager::handleClaim` or `Model::h
* This method creates a new `IndividualClaimWindow` with the claim object that was passed as a parameter. If the window is not showing, the
`IndividualClaimWindow::show` method is called else it will call the `IndividualClaimWindow::focus` method to focus on the current claim.

==== Why was it implemented this way?
The pop-up method seems to be the best way to attract the attention of the user and make sure that the user can see clearly what he wants to
check at that point in time. A pop-up is also easy because it allows the user to return immediately to the lists of claims or contacts and he/she
can continue to work on his tasks immediately.

==== Alternatives Considered

[appendix]
Expand Down
5 changes: 3 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#Tue Oct 22 23:21:37 SGT 2019
distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-all.zip
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
2 changes: 1 addition & 1 deletion src/main/java/seedu/address/MainApp.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
*/
public class MainApp extends Application {

public static final Version VERSION = new Version(0, 6, 0, true);
public static final Version VERSION = new Version(1, 3, 1, true);

private static final Logger logger = LogsCenter.getLogger(MainApp.class);

Expand Down

0 comments on commit 493acee

Please sign in to comment.