Improve body measurement field #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngchisern
commented
Oct 30, 2021
•
ngchisern
commented
- Modify the class so that it accepts 'double' input
- Add lower and upper bound for measurements
- Fix inconsistent measurement prefix in UG
- Correct wrong format for edit & edittask command in UG
- Add file locations of taskbook and orderbook in UI
ngchisern
added
type.Bug
This was
linked to
issues
Oct 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
============================================
- Coverage 58.94% 58.55% -0.40%
- Complexity 679 681 +2
============================================
Files 134 134
Lines 2609 2642 +33
Branches 300 304 +4
============================================
+ Hits 1538 1547 +9
- Misses 981 1001 +20
- Partials 90 94 +4
Continue to review full report at Codecov.
|
GnohChengYi
requested changes
Nov 1, 2021
* master: Update help command image Fix issues raised in PR Fix issue from PR review Update TaskList to UniqueTaskList Fix typo in UG for marktask command Update ListXCommand message Add upper limit on phone number field Update add command UG documentation Update display message to user for add and list commands Update MarkTaskCommand when task already marked Update UG to remind users modify measurement when they are editing the gender Update MarkOrderCommand when order already marked Improve error message for the case where the measurements are not modified when gender is edited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.