Update MarkTaskCommand when task already marked #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If attempting to mark an task that is already done, a new message is given to the user. * Have changed the function from setIsDone() to markDone(), since we do not allow undo of completion. The function will return a boolean hasChanged informing the caller whether or not there was a change made to the task status. * Testcases were updated
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
============================================
+ Coverage 58.94% 59.08% +0.13%
- Complexity 679 681 +2
============================================
Files 134 134
Lines 2609 2610 +1
Branches 300 301 +1
============================================
+ Hits 1538 1542 +4
+ Misses 981 978 -3
Partials 90 90
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a new message is given to the user.
since we do not allow undo of completion. The function will return
a boolean hasChanged informing the caller whether or not there
was a change made to the task status.