Skip to content

Commit

Permalink
Merge pull request #160 from ivorcmx/update-DGDiagram
Browse files Browse the repository at this point in the history
Update dg diagram
  • Loading branch information
putaojuice authored Apr 11, 2022
2 parents 2e5c8fa + 199b382 commit e843937
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ The `Model` component,
<img src="images/StorageClassDiagram.png" width="550" />

The `Storage` component,
* can save both address book data and user preference data in json format, and read them back into corresponding objects.
* inherits from both `AddressBookStorage` and `UserPrefStorage`, which means it can be treated as either one (if only the functionality of only one is needed).
* can save address book data, task list data and user preference data in json format, and read them back into corresponding objects.
* inherits from `AddressBookStorage`, `TaskListStorage` and `UserPrefStorage`, which means it can be treated as any one (if only the functionality of only one is needed).
* depends on some classes in the `Model` component (because the `Storage` component's job is to save/retrieve objects that belong to the `Model`)

### Common classes
Expand Down
14 changes: 13 additions & 1 deletion docs/diagrams/StorageClassDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ Class JsonAdaptedPerson
Class JsonAdaptedTag
}

package "TaskList Storage" #F4F6F6{
Class "<<interface>>\nTaskListStorage" as TaskListStorage
Class JsonTaskListStorage
Class JsonSerializableTaskList
Class JsonAdaptedTask
}

}

Class HiddenOutside #FFFFFF
Expand All @@ -30,14 +37,19 @@ HiddenOutside ..> Storage
StorageManager .up.|> Storage
StorageManager -up-> "1" UserPrefsStorage
StorageManager -up-> "1" AddressBookStorage
StorageManager -up-> "1" TaskListStorage

Storage -left-|> UserPrefsStorage
Storage -right-|> UserPrefsStorage
Storage -right-|> AddressBookStorage
Storage -right-|> TaskListStorage

JsonUserPrefsStorage .up.|> UserPrefsStorage
JsonAddressBookStorage .up.|> AddressBookStorage
JsonAddressBookStorage ..> JsonSerializableAddressBook
JsonSerializableAddressBook --> "*" JsonAdaptedPerson
JsonAdaptedPerson --> "*" JsonAdaptedTag
JsonTaskListStorage .up.|> TaskListStorage
JsonTaskListStorage ..> JsonSerializableTaskList
JsonSerializableTaskList --> "*" JsonAdaptedTask

@enduml
Binary file modified docs/images/StorageClassDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/UiClassDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions docs/team/ivorcmx.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Given below are my contributions to the project.
* **Tests Written**:
* `DeleteTaskCommandTest`
* `DeleteTaskCommandParserTest`
<div style="page-break-after: always;"></div>
* **Additional info**:
* Updated ParserUtil method of parseNumber to work with DeleteTaskCommand
* Added relevant activity and sequence diagrams into Developer Guide
Expand Down

0 comments on commit e843937

Please sign in to comment.