Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] Suggestion on colour scheme used. #120

Closed
soc-pe-bot opened this issue Apr 1, 2022 · 1 comment · Fixed by #157
Closed

[PE-D] Suggestion on colour scheme used. #120

soc-pe-bot opened this issue Apr 1, 2022 · 1 comment · Fixed by #157
Assignees
@SimJM @tanweien
Milestone
v1.4

Comments

@soc-pe-bot
Copy link

This is not really a bug but more of a suggestion where it would be better to use darker colours when displaying the result sucess as white on bright orange is quite straining to the eyes. (Can be sometimes hard to read as well).

image.png

Labels: severity.Low type.FeatureFlaw
original: ChanWeiJie/ped#2
@tanweien tanweien self-assigned this Apr 3, 2022
@SimJM SimJM self-assigned this Apr 6, 2022
@SimJM
Copy link

SimJM commented Apr 6, 2022

similar to #113

SimJM added a commit to SimJM/tp that referenced this issue Apr 6, 2022
@SimJM
fixes AY2122S2-CS2103T-W11-4#113 and AY2122S2-CS2103T-W11-4#120 regar…
7da7fa4 
…ding color schemes of UI

1. Text colour in the orange text box can make it hard to read messages.
2. Suggestion on colour scheme used.
@SimJM SimJM mentioned this issue Apr 6, 2022
Merged
@ghost ghost closed this as completed in #157 Apr 6, 2022
@SimJM SimJM added this to the v1.4 milestone Apr 8, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimJM SimJM

@tanweien tanweien

Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

PE-Dry fixes SimJM/tp
3 participants
@SimJM @tanweien @soc-pe-bot