Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-Dry fixes #157

Merged
7 commits merged into from
Apr 6, 2022
Merged

PE-Dry fixes #157

7 commits merged into from
Apr 6, 2022

Conversation

SimJM
Copy link

@SimJM SimJM commented Apr 6, 2022

fixes #113
fixes #120
fixes #151
fixes #137
fixes #144
fixes #117
fixes #123

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #157 (172e0db) into master (b181106) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #157   +/-   ##
=========================================
  Coverage     76.78%   76.78%           
  Complexity      577      577           
=========================================
  Files            92       92           
  Lines          1680     1680           
  Branches        170      170           
=========================================
  Hits           1290     1290           
  Misses          340      340           
  Partials         50       50           
Impacted Files Coverage Δ
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/person/Email.java 90.00% <ø> (ø)
src/main/java/seedu/address/model/tag/Tag.java 80.00% <ø> (ø)
...in/java/seedu/address/model/telegram/Telegram.java 90.90% <ø> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b181106...172e0db. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you jiaming!

@ghost ghost merged commit 65c59c9 into AY2122S2-CS2103T-W11-4:master Apr 6, 2022
@shurvirarora shurvirarora added this to the v1.4 milestone Apr 6, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment