Team Fix #171
Team Fix #171
Conversation
…lete team commands, remove team members and task from Team.toString() method
Codecov ReportBase: 39.13% // Head: 39.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
============================================
- Coverage 39.13% 39.07% -0.07%
- Complexity 457 471 +14
============================================
Files 143 147 +4
Lines 2619 2672 +53
Branches 327 340 +13
============================================
+ Hits 1025 1044 +19
- Misses 1529 1551 +22
- Partials 65 77 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/main/java/seedu/address/logic/commands/DeleteTeamCommand.java
Outdated
Show resolved
Hide resolved
|
|
||
| public static final TeamName DEFAULT_NAME = new TeamName("default"); | ||
|
|
||
| public final String teamName; |
There was a problem hiding this comment.
Are we making Name class in the models folder which the Person, Team, and Task models are inheriting from?
There was a problem hiding this comment.
I think better not bah, better to create custom classes for the names that Person Teams and Tasks use because they might have different validation regex
| public static boolean isValidTeamDescription(String test) { | ||
| return test.matches(DESCRIPTION_VALIDATION_REGEX); | ||
| } | ||
|
|
||
| /** | ||
| * Returns true if both teams have the same name. |
There was a problem hiding this comment.
Can you rename this function to hasSameTeamName instead?
There was a problem hiding this comment.
I think its better to leave it as isSameTeam, since Person has a isSamePerson method which defines weak equality.
Changes
Fixes
edit_teamoutput #117