Update DG for new feature flaws #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
imkwokyong
requested changes
Nov 12, 2023
docs/DeveloperGuide.md
Outdated
Comment on lines
825
to
826
| 1. In the current implementation, `filter` only works for 1 field. The user may want to filter for multiple fields so that they can have an easier time finding people of interest. | ||
| 2. Proposed solution: We plan to let `filter` filter for multiple fields. |
There was a problem hiding this comment.
Also I think is good to add filtering for note, schedule and schedule name here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scheduleName and name feature flaw and filter feature flaw