Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve email regex #194

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

nixonwidjaja
Copy link

No description provided.

@nixonwidjaja nixonwidjaja requested a review from a team November 11, 2023 22:15
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52321df) 79.87% compared to head (d2ad782) 79.87%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #194   +/-   ##
=========================================
  Coverage     79.87%   79.87%           
  Complexity      761      761           
=========================================
  Files           103      103           
  Lines          2331     2331           
  Branches        283      283           
=========================================
  Hits           1862     1862           
  Misses          398      398           
  Partials         71       71           
Files Coverage Δ
...rc/main/java/seedu/address/model/person/Email.java 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nixonwidjaja nixonwidjaja requested review from a team and removed request for a team November 11, 2023 22:16
Copy link

@remuslum remuslum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remuslum remuslum merged commit a2501de into AY2324S1-CS2103-F13-2:master Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants