Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor edit sequence diagram #201

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Minor edit sequence diagram #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cab8e0
Change the "or" to "and" in the view leave sequence diagram
marcellaantania Nov 12, 2023
fa9ce9c
Delete John Doe from teams
marcellaantania Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/diagrams/ViewLeaveCommandSequenceDiagram.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ ViewLeaveCommandParser -> HasLeaveAnyMonthPredicate : new HasLeaveAnyMonthPredic
activate HasLeaveAnyMonthPredicate

create MatchingDepartmentPredicate
HasLeaveAnyMonthPredicate -> MatchingDepartmentPredicate : or(new MatchingDepartmentPredicate(Engineering))
HasLeaveAnyMonthPredicate -> MatchingDepartmentPredicate : and(new MatchingDepartmentPredicate(Engineering))
activate MatchingDepartmentPredicate

MatchingDepartmentPredicate --> HasLeaveAnyMonthPredicate : combinedPredicate
MatchingDepartmentPredicate --> HasLeaveAnyMonthPredicate
deactivate MatchingDepartmentPredicate

HasLeaveAnyMonthPredicate --> ViewLeaveCommandParser
HasLeaveAnyMonthPredicate --> ViewLeaveCommandParser : combinedPredicate
deactivate HasLeaveAnyMonthPredicate

create ViewLeaveCommand
Expand Down
Binary file modified docs/images/ViewLeaveCommandSequenceDiagram.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
46 changes: 0 additions & 46 deletions docs/team/johndoe.md
View file
Open in desktop

This file was deleted.

Loading