Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phone bug #205

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fix phone bug #205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b373b2
Fix phone bug
nixonwidjaja Nov 13, 2023
ac83f53
Add constraint
nixonwidjaja Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/seedu/address/model/person/Phone.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,14 @@ public Phone(String phone) {
* Returns true if a given string is a valid phone number.
*/
public static boolean isValidPhone(String test) {
if (test.length() < 3 || test.length() > 20) {
if (test.length() < 3) {
return false;
}
if (test.charAt(0) == '+') {
return test.substring(1).matches(VALIDATION_REGEX);
test = test.substring(1);
}
if (test.length() < 3 || test.length() > 20) {
return false;
}
return test.matches(VALIDATION_REGEX);
}
Expand Down
Loading