Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add leave #62

Merged
merged 19 commits into from
Oct 14, 2023
Merged

Feat: Add leave #62

merged 19 commits into from
Oct 14, 2023

Conversation

nixonwidjaja
Copy link

No description provided.

@nixonwidjaja nixonwidjaja changed the title Add and view leave Feat: Add leave Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6a3a32e) 75.46% compared to head (fb864db) 77.92%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
+ Coverage     75.46%   77.92%   +2.46%     
- Complexity      471      536      +65     
============================================
  Files            79       82       +3     
  Lines          1565     1735     +170     
  Branches        155      186      +31     
============================================
+ Hits           1181     1352     +171     
+ Misses          333      327       -6     
- Partials         51       56       +5     
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 90.90% <ø> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 90.90% <100.00%> (+0.43%) ⬆️
...ain/java/seedu/address/logic/parser/CliSyntax.java 91.66% <100.00%> (+0.75%) ⬆️
...seedu/address/logic/parser/LeaveCommandParser.java 100.00% <100.00%> (ø)
...rc/main/java/seedu/address/model/person/Leave.java 100.00% <100.00%> (ø)
...c/main/java/seedu/address/model/person/Person.java 98.33% <100.00%> (+2.77%) ⬆️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% <ø> (ø)
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø)
... and 2 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nixonwidjaja nixonwidjaja linked an issue Oct 12, 2023 that may be closed by this pull request
@nixonwidjaja nixonwidjaja added this to the v1.2b milestone Oct 12, 2023
@nixonwidjaja nixonwidjaja marked this pull request as ready for review October 12, 2023 20:30
@nixonwidjaja nixonwidjaja requested a review from a team October 12, 2023 20:30
@sheryew
Copy link

sheryew commented Oct 14, 2023

The success command for adding leave is too long and unreadable.
Perhaps shorten the success response to something like:
Leave(s) successfully updated for employee: Alex Yeoh.
Added Leaves for January
Deleted leaves for Feb.

Something along that line

Copy link

@sheryew sheryew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sheryew sheryew merged commit fa21a56 into master Oct 14, 2023
8 checks passed
@nixonwidjaja nixonwidjaja modified the milestones: v1.2b, v1.2 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add leaves
2 participants