Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified delete command #67

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

remuslum
Copy link

Update of delete command

The current codebase shows all information of the deleted employee, which is unnecessary.

Hence, I have modified the success message to only show the deleted employee's name.

@remuslum remuslum added this to the v1.2 milestone Oct 11, 2023
@remuslum remuslum linked an issue Oct 11, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6a3a32e) 75.46% compared to head (28a438e) 75.46%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage     75.46%   75.46%           
  Complexity      471      471           
=========================================
  Files            79       79           
  Lines          1565     1565           
  Branches        155      155           
=========================================
  Hits           1181     1181           
  Misses          333      333           
  Partials         51       51           
Files Coverage Δ
...va/seedu/address/logic/commands/DeleteCommand.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nixonwidjaja nixonwidjaja merged commit f0c8bf9 into AY2324S1-CS2103-F13-2:master Oct 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete an employees by specified index
2 participants