Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs on Birthday, Money, ClaimCommandParser #69

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

nixonwidjaja
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6a3a32e) 75.46% compared to head (b18a3fd) 75.62%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
+ Coverage     75.46%   75.62%   +0.16%     
  Complexity      471      471              
============================================
  Files            79       79              
  Lines          1565     1563       -2     
  Branches        155      154       -1     
============================================
+ Hits           1181     1182       +1     
+ Misses          333      330       -3     
  Partials         51       51              
Files Coverage Δ
...seedu/address/logic/parser/ClaimCommandParser.java 100.00% <100.00%> (ø)
...rc/main/java/seedu/address/model/person/Money.java 70.37% <100.00%> (+7.03%) ⬆️
...main/java/seedu/address/model/person/Birthday.java 69.56% <66.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nixonwidjaja nixonwidjaja requested a review from a team October 12, 2023 16:32
@nixonwidjaja nixonwidjaja added this to the v1.2 milestone Oct 12, 2023
Copy link

@sheryew sheryew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@sheryew sheryew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sheryew sheryew merged commit 8376341 into master Oct 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants