Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leave bugs #75

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Fix leave bugs #75

merged 5 commits into from
Oct 18, 2023

Conversation

nixonwidjaja
Copy link

No description provided.

@nixonwidjaja nixonwidjaja linked an issue Oct 18, 2023 that may be closed by this pull request
@nixonwidjaja nixonwidjaja added this to the v1.2b milestone Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7ef9bd4) 77.27% compared to head (353e249) 77.44%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #75      +/-   ##
============================================
+ Coverage     77.27%   77.44%   +0.17%     
- Complexity      563      570       +7     
============================================
  Files            84       84              
  Lines          1844     1858      +14     
  Branches        213      218       +5     
============================================
+ Hits           1425     1439      +14     
  Misses          346      346              
  Partials         73       73              
Files Coverage Δ
...ava/seedu/address/logic/commands/LeaveCommand.java 97.22% <100.00%> (+0.25%) ⬆️
...seedu/address/logic/parser/LeaveCommandParser.java 100.00% <100.00%> (ø)
...rc/main/java/seedu/address/model/person/Leave.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@marcellaantania marcellaantania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcellaantania marcellaantania merged commit f830865 into master Oct 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add leave bug fixes
2 participants