Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG #280

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Update DG #280

merged 9 commits into from
Nov 13, 2023

Conversation

frrrrry
Copy link

@frrrrry frrrrry commented Nov 13, 2023

  • Add content page for dg
  • Add implementation for features delete, unfav and proposed edit feature
  • Update implementation for fav feature
  • Add line breaks for pdf conversion
  • Change version number for release
  • Update fry's ppp

@frrrrry frrrrry added this to the v1.4 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3e8fe70) 77.40% compared to head (7388927) 77.40%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #280   +/-   ##
=========================================
  Coverage     77.40%   77.40%           
  Complexity      579      579           
=========================================
  Files            89       89           
  Lines          1894     1894           
  Branches        183      183           
=========================================
  Hits           1466     1466           
  Misses          386      386           
  Partials         42       42           
Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@xxiaoweii xxiaoweii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@xxiaoweii xxiaoweii merged commit 038cc81 into master Nov 13, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants