Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds William's description and image in aboutUs.ms #29

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

wjacobw
Copy link

@wjacobw wjacobw commented Oct 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8b8ebb3) 75.26% compared to head (289e90c) 75.26%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frrrrry frrrrry added this to the v1.1 milestone Oct 2, 2023
Copy link

@frrrrry frrrrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@frrrrry frrrrry merged commit 9d76f1d into AY2324S1-CS2103T-F08-0:master Oct 2, 2023
5 checks passed
Copy link

@frrrrry frrrrry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should name your image file name as your github username. Other than the mentioned nit, the rest lgtm. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants