Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a PR template #17

Merged

Conversation

HugeNoob
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Add a new PR template so that we can have descriptive PR descriptions.

Related Tickets & Documents

None

Added/updated tests?

We encourage you to keep the code coverage percentage at 75% and above for new changes.

  • Yes
  • No, and this is why: Bruh no need to test md files.
  • No, there are UI changes that I'm unable to cover.
  • I need help with writing tests

@HugeNoob HugeNoob self-assigned this Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #17 (54e9e48) into master (9242d8d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@m1oojv m1oojv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@freshcabbage123 freshcabbage123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@freshcabbage123 freshcabbage123 merged commit 68cfd6e into AY2324S1-CS2103T-T10-2:master Sep 21, 2023
5 checks passed
@jiakai-17 jiakai-17 added the type.Chore Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Chore Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants