Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract tag function and Edit AboutUs #5

Merged
merged 11 commits into from
Oct 3, 2023

Conversation

YeoBohShin
Copy link

@YeoBohShin YeoBohShin commented Sep 27, 2023

Made the Tag function isolated from Edit function.

But now still tagging with index instead of student
number.

Edited the About us to include all members

Added each member's skeleton for portfoilio

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #5 (eb197b0) into master (5517080) will increase coverage by 0.47%.
The diff coverage is 89.36%.

❗ Current head eb197b0 differs from pull request most recent head 2a231a7. Consider uploading reports for the commit 2a231a7 to get more accurate results

@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
+ Coverage     75.26%   75.74%   +0.47%     
- Complexity      419      437      +18     
============================================
  Files            71       73       +2     
  Lines          1338     1385      +47     
  Branches        126      133       +7     
============================================
+ Hits           1007     1049      +42     
  Misses          301      301              
- Partials         30       35       +5     
Files Coverage Δ
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <100.00%> (ø)
...ain/java/seedu/address/logic/parser/CliSyntax.java 85.71% <100.00%> (+2.38%) ⬆️
.../java/seedu/address/logic/commands/TagCommand.java 92.59% <92.59%> (ø)
...a/seedu/address/logic/parser/TagCommandParser.java 83.33% <83.33%> (ø)

About us shows what our
product is about and each
members contribution to the
project.

Added Profile picture and
skeletion for each member's
portfolio
Added testing for Tagcommand
@YeoBohShin YeoBohShin changed the title Extracted tag function Extract tag function and Edit AboutUs Oct 3, 2023
Fix order of import statements
in TagCommandTest
Update AboutUs and each
members portfolio to follow
checkstyle
Added testing for
TagCommandParser
@YeoBohShin YeoBohShin merged commit 4f81c9e into AY2324S1-CS2103T-T11-1:master Oct 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant