Modify delete using student number #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LWZ19
reviewed
Oct 13, 2023
| @@ -14,7 +14,9 @@ public class Messages { | |||
|
|
|||
| public static final String MESSAGE_UNKNOWN_COMMAND = "Unknown command"; | |||
| public static final String MESSAGE_INVALID_COMMAND_FORMAT = "Invalid command format! \n%1$s"; | |||
| public static final String MESSAGE_INVALID_PERSON_DISPLAYED_INDEX = "The person index provided is invalid"; | |||
| public static final String MESSAGE_INVALID_PERSON_DISPLAYED_INDEX = "The peron index provided is invalid"; | |||
There was a problem hiding this comment.
Small spelling mistake here for 'person'
Comment on lines
20
to
22
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Deletes a person. " | ||
| + "Parameters: " | ||
| + PREFIX_STUDENTNUMBER + "STUDENT NUMBER" |
There was a problem hiding this comment.
Newline could be added for better readability. 😊
Suggested change
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Deletes a person. " | |
| + "Parameters: " | |
| + PREFIX_STUDENTNUMBER + "STUDENT NUMBER" | |
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Deletes a person.\n" | |
| + "Parameters: " | |
| + PREFIX_STUDENTNUMBER + "STUDENT NUMBER\n" |
Cikguseven
reviewed
Oct 14, 2023
| throw new CommandException(Messages.MESSAGE_INVALID_STUDENT_NUMBER); | ||
| } | ||
|
|
||
| if (!model.hasPerson(new Person(targetStudentNumber))) { |
There was a problem hiding this comment.
Is it possible to check if model has person using Student number without creating a Person object?
added 2 commits
October 14, 2023 13:51
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
============================================
+ Coverage 77.28% 77.34% +0.05%
+ Complexity 492 491 -1
============================================
Files 78 78
Lines 1585 1598 +13
Branches 158 153 -5
============================================
+ Hits 1225 1236 +11
- Misses 313 314 +1
- Partials 47 48 +1
|
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55