Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PPP skeleton for Di Sheng #24

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Create PPP skeleton for Di Sheng #24

merged 1 commit into from
Sep 29, 2023

Conversation

dishenggg
Copy link

closes #11

@dishenggg dishenggg added priority.High Must do type.Documentation Documentation and user guide labels Sep 28, 2023
@dishenggg dishenggg added this to the v1.1 milestone Sep 28, 2023
@dishenggg dishenggg self-assigned this Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #24 (69bc47d) into master (cb2d876) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Jweng88
Jweng88 approved these changes Sep 28, 2023
View reviewed changes
Copy link

@Jweng88 Jweng88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfjkri mfjkri merged commit df7dd47 into AY2324S1-CS2103T-T17-3:master Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jweng88 Jweng88 Jweng88 approved these changes

Assignees

@dishenggg dishenggg

Labels
priority.High Must do type.Documentation Documentation and user guide
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Create PPP Skeleton for Di Sheng
3 participants
@dishenggg @Jweng88 @mfjkri