Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG #333

Merged
Merged

Conversation

ruishanteo
Copy link

@ruishanteo ruishanteo commented Nov 11, 2023

  • Removed unneeded prerequisites from manual testing
  • Edit edit-t name (so that manual testing can be done sequentially)
  • Add info box about lifeline for add-t
  • Update planned enhancements
  • Add design rationale for mark

@ruishanteo ruishanteo self-assigned this Nov 11, 2023
@ruishanteo ruishanteo added priority.High Must do type.Documentation Documentation and user guide labels Nov 11, 2023
Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for tp17 ready!

Name Link
🔨 Latest commit ed5e038
🔍 Latest deploy log https://app.netlify.com/sites/tp17/deploys/65502893f119c20008a1905f
😎 Deploy Preview https://deploy-preview-333--tp17.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #333 (ed5e038) into master (27bcb7b) will increase coverage by 0.05%.
Report is 11 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #333      +/-   ##
============================================
+ Coverage     77.11%   77.16%   +0.05%     
+ Complexity      724      723       -1     
============================================
  Files           106      106              
  Lines          2189     2181       -8     
  Branches        231      229       -2     
============================================
- Hits           1688     1683       -5     
+ Misses          480      477       -3     
  Partials         21       21              

see 3 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ruishanteo ruishanteo marked this pull request as draft November 11, 2023 05:20
@ruishanteo ruishanteo marked this pull request as ready for review November 11, 2023 08:33
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
Co-authored-by: Jweng88 <[email protected]>
@ruishanteo ruishanteo requested a review from dishenggg November 12, 2023 01:23
@ruishanteo ruishanteo added this to the v1.4 milestone Nov 12, 2023
Copy link

@mfjkri mfjkri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfjkri
Copy link

mfjkri commented Nov 12, 2023

Thanks!! I think we are done?!!!

@mfjkri mfjkri merged commit 607623f into AY2324S1-CS2103T-T17-3:master Nov 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Documentation Documentation and user guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants