Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sequence diagram for edit-s #358

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,6 @@ the lifeline reaches the end of diagram.
#### Design rationale
{:.no_toc}

The `add-t` command was designed this way to ensure consistency with the previous `add` command in AB3.

**Aspect: Optional fields**
* **Alternative 1:** Allow optional fields when adding tutor (e.g. user can omit phone number or email when adding a
tutor).
Expand Down
18 changes: 5 additions & 13 deletions docs/diagrams/EditScheduleSequenceDiagram.puml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ box Logic LOGIC_COLOR_T1
participant ":LogicManager" as LogicManager LOGIC_COLOR
participant ":AddressBookParser" as AddressBookParser LOGIC_COLOR
participant ":EditSchedule\nCommandParser" as EditScheduleCommandParser LOGIC_COLOR
participant "e:EditSchedule\nDescriptor" as EditScheduleDescriptor LOGIC_COLOR
participant "d:EditSchedule\nCommand" as EditScheduleCommand LOGIC_COLOR
participant "r:CommandResult" as CommandResult LOGIC_COLOR
participant "s:Schedule" as EditedSchedule MODEL_COLOR
participant "e:Schedule" as EditedSchedule MODEL_COLOR
end box

box Model MODEL_COLOR_T1
Expand All @@ -32,13 +31,6 @@ deactivate EditScheduleCommandParser
AddressBookParser -> EditScheduleCommandParser : parse("1 st/2023-09-15T09:00")
activate EditScheduleCommandParser

create EditScheduleDescriptor
EditScheduleCommandParser -> EditScheduleDescriptor
activate EditScheduleDescriptor

EditScheduleDescriptor --> EditScheduleCommandParser : e
deactivate EditScheduleDescriptor

create EditScheduleCommand
EditScheduleCommandParser -> EditScheduleCommand
activate EditScheduleCommand
Expand All @@ -63,21 +55,21 @@ return

create EditedSchedule
EditScheduleCommand -> EditedSchedule ++
return s
EditScheduleCommand -> Model ++ : hasSchedule(s)
return e
EditScheduleCommand -> Model ++ : hasSchedule(e)
return

EditScheduleCommand -> Model ++ : getAddressBook()
return

loop number of schedules in model
EditScheduleCommand -> EditedSchedule : isClashing(s)
EditScheduleCommand -> EditedSchedule : isClashing(e)
activate EditedSchedule
EditedSchedule --> EditScheduleCommand
deactivate EditedSchedule
end

EditScheduleCommand -> Model ++ : setSchedule(scheduleToEdit, s)
EditScheduleCommand -> Model ++ : setSchedule(scheduleToEdit, e)
return
EditScheduleCommand -> Model ++ : updateFilteredScheduleList()
return
Expand Down
Binary file modified docs/images/EditScheduleSequenceDiagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading