Merge pull request #108 from samuelmui8/branch-storage

Fix storage bug where itemReview is null
AY2324S1-CS2103T-W10-4 · Oct 26, 2023 · b138bfe · b138bfe
2 parents c268c91 + 7ba71b5
commit b138bfe
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/main/java/seedu/address/storage/JsonAdaptedItem.java b/src/main/java/seedu/address/storage/JsonAdaptedItem.java
@@ -49,13 +49,17 @@ public Item toModelType() throws IllegalValueException {
             throw new IllegalValueException(ItemName.MESSAGE_CONSTRAINTS);
         }
         final ItemName modelName = new ItemName(itemName);
-        Item item = new Item(modelName);
 
-        final ItemReview modelItemReview = itemReview.toModelType();
+        ItemReview modelItemReview = null;
+
+        if (itemReview != null) {
+            modelItemReview = itemReview.toModelType();
+        }
 
         if (modelItemReview != null) {
-            item.setItemReview(modelItemReview);
+            return new Item(modelName, modelItemReview);
+        } else {
+            return new Item(modelName);
         }
-        return item;
     }
 }