Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Bug Fix #214

Merged
Merged

Conversation

jamesebond
Copy link

Fix Error message on entering integers less than equal 0/non-integers

teoks0199
teoks0199 previously approved these changes Nov 8, 2023
Copy link

@teoks0199 teoks0199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93d6ec6) 54.00% compared to head (6ae798d) 61.14%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #214      +/-   ##
============================================
+ Coverage     54.00%   61.14%   +7.13%     
- Complexity      573      622      +49     
============================================
  Files           124      124              
  Lines          2444     2455      +11     
  Branches        248      248              
============================================
+ Hits           1320     1501     +181     
+ Misses         1059      885     -174     
- Partials         65       69       +4     
Files Coverage Δ
...address/logic/parser/DeleteStallCommandParser.java 78.57% <100.00%> (+1.64%) ⬆️
...in/java/seedu/address/logic/parser/ParserUtil.java 97.67% <100.00%> (+9.30%) ⬆️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@samuelmui8 samuelmui8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samuelmui8 samuelmui8 merged commit 7bb3818 into AY2324S1-CS2103T-W10-4:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester E] Error message on entering integers less than equal 0/non-integers can be more accurate
3 participants