Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use cases in DG #262

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Update use cases in DG #262

merged 9 commits into from
Nov 13, 2023

Conversation

JasonRay168
Copy link

No description provided.

LordSaumya
LordSaumya previously approved these changes Nov 13, 2023
Copy link
Member

@LordSaumya LordSaumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, needs minor changes

Copy link

@inezkok inezkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! i commented on some minor things you might have missed out on!

docs/DeveloperGuide.md Show resolved Hide resolved
docs/DeveloperGuide.md Show resolved Hide resolved
docs/DeveloperGuide.md Show resolved Hide resolved
docs/DeveloperGuide.md Show resolved Hide resolved

**Extensions**

* 1a. User leaves out parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be more specific about which parameters are left out


**Extensions**

* 1a. User leaves out parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be more specific about which parameters are left out

**MSS**

1. User requests to add a given remark to an employee with a given employee id.
2. HouR adds the remark to the list of remarks associated with the employee with the given employee id.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use case stories should alternate between the system and the user


**Extensions**

* 1a. User leaves out parameters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be more specific about which parameters


1. User requests to delete a given remark from an employee with a given employee id.
2. HouR deletes the remark from the list of remarks associated with the employee with the given employee id.
3. HouR shows the list of remarks associated with the employee with the given employee id.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSS should alternate between user and system

@LordSaumya LordSaumya dismissed their stale review November 13, 2023 04:36

Needs minor changes

@inezkok inezkok added this to the v1.4b milestone Nov 13, 2023
Copy link

@inezkok inezkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@inezkok inezkok merged commit 73f7a88 into master Nov 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants