Skip to content

Commit

Permalink
Add reviews on other teams' PR
Browse files Browse the repository at this point in the history
  • Loading branch information
ziyi105 committed Nov 13, 2023
1 parent 77e1c72 commit 5c1113c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions docs/team/ziyi105.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,14 @@ Café proprietors who prefer typing on CLI than any other interaction method and
6. Glossary
7. General formatting
- Ensure consistency of features descriptions and diagrams
- Correct typos and grammar error
- Correct typos and grammar errors

### Other Contributions to Team-based Task
1. Maintaining issue tracker with Dexter by labeling issues
2. Adding theme to UG & DG
3. Approving and merging PRs
4. Reminding team members to use github effectively (although some of my reminders were ignored :")
4. Checking coding standard for most of the classes ([PR #351](https://github.com/AY2324S1-CS2113-T17-2/tp/pull/351))
5. Reminding team members to use github effectively (although some of my reminders were ignored :")
- I encouraged my team members to report bugs using issue tracker on Github instead of using Telegram. (e.g., [#323](https://github.com/AY2324S1-CS2113-T17-2/tp/issues/323))
- I requested PR reviews from my team members as I noticed they haven't had a chance to do any review. (e.g., [PR #51](https://github.com/AY2324S1-CS2113-T17-2/tp/pull/51))

Expand All @@ -113,4 +114,4 @@ Café proprietors who prefer typing on CLI than any other interaction method and
### Contributions beyond the Project Team
1. Posted 9 posts in the forum.
Examples of forum posts: [#37](https://github.com/nus-cs2113-AY2324S1/forum/issues/37), [#19](https://github.com/nus-cs2113-AY2324S1/forum/issues/19), [#31](https://github.com/nus-cs2113-AY2324S1/forum/issues/31)
2. Reviews on PR from other teams: [T18-1](https://github.com/nus-cs2113-AY2324S1/tp/pull/19#discussion_r1379823357)
2. Reviews on PR from other teams: [T18-1](https://github.com/nus-cs2113-AY2324S1/tp/pull/19#discussion_r1379823357), [F11-3](https://github.com/nus-cs2113-AY2324S1/tp/pull/28)

0 comments on commit 5c1113c

Please sign in to comment.