Add assertion into CafeCtrl #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DextheChik3n
reviewed
Nov 7, 2023
| @@ -35,6 +35,7 @@ private CafeCtrl() { | |||
| this.pantry = this.storage.loadPantryStock(); | |||
| this.sales = this.storage.loadOrderList(menu); | |||
| this.currentDate = new CurrentDate(sales); | |||
| assert !sales.getOrderLists().isEmpty(); | |||
There was a problem hiding this comment.
could you perhaps add a newline before this statement to show clear sections for set up and testing
There was a problem hiding this comment.
Also, would this assert statement get triggered whenever the application is launch for the first time?
There was a problem hiding this comment.
oh sorry misunderstood that the sales is a array of order list not an array of orders
DextheChik3n
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.