Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 8, 12 Create parser class and parser test class #32

Merged
merged 5 commits into from
Oct 15, 2023
Merged

Task 8, 12 Create parser class and parser test class #32

merged 5 commits into from
Oct 15, 2023

Conversation

ziyi105
Copy link

@ziyi105 ziyi105 commented Oct 14, 2023

fixes 8, fixes 12

@ziyi105 ziyi105 marked this pull request as draft October 14, 2023 16:06
@ziyi105 ziyi105 marked this pull request as ready for review October 14, 2023 16:06
DextheChik3n
DextheChik3n reviewed Oct 15, 2023
View reviewed changes
src/test/java/seedu/duke/parser/ParserTest.java
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create Javadoc for ParserTest class pleeease

DextheChik3n
DextheChik3n requested changes Oct 15, 2023
View reviewed changes
Copy link

@DextheChik3n DextheChik3n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include a short javadoc for ParserTest class (also lowkey testing what happens when I submit review with "Request changes" option)

DextheChik3n
DextheChik3n approved these changes Oct 15, 2023
View reviewed changes
Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classes are well named 👍

@DextheChik3n DextheChik3n merged commit d89e310 into AY2324S1-CS2113-T17-2:master Oct 15, 2023
3 checks passed
@ziyi105 ziyi105 added this to the v0.1 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DextheChik3n DextheChik3n DextheChik3n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ziyi105 @DextheChik3n