Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 342, Update DG, UG and PPP #343

Merged
merged 20 commits into from
Nov 13, 2023
Merged

Task 342, Update DG, UG and PPP #343

merged 20 commits into from
Nov 13, 2023

Conversation

NaychiMin
Copy link

Fixes #342
Fixes #256
Fixes #242
Fixes #241
Fixes #235

@NaychiMin
Add in sequence diagram for list_ingredients command.
e60a02a
@NaychiMin
Add in sequence diagram for list_sale command.
3ef9520
@NaychiMin
Add in sequence diagram for isDishCooked() function in Pantry class.
df55bc8
@NaychiMin
Add in sequence diagram for calculateMaxDish() function in Pantry class.
ede4342
@NaychiMin
Improve coding standard.
9c80fc3
@NaychiMin
Edit List_ingredient command in DG with updated sequence diagram.
8d2f29e
@NaychiMin
Add in sequence diagram and necessary description into DG for
b4acb84 
list_sale command.
@NaychiMin
Add in sequence diagram and description for isDishCooked() function from
ad81169 
Pantry class in DG.
@NaychiMin
Add in sequence diagram and description for calculateMaxDish() function
c460bae 
from Pantry class in DG.
@NaychiMin
Removed unused sequence diagram.
23d7f8b
@NaychiMin
Update table of contents in DG with changes made.
0b28754
@NaychiMin
Update user guide with edited command tag for list_ingredients.
68a532c
@NaychiMin
Improve code quality.
90d7528
@NaychiMin
Edit PPP and renamed PPP folder to all small caps of github user name.
00d977d
@NaychiMin
Merge branch 'master' into Update-DG-with-changes-made-v2.1
03cc365 
# Conflicts:
#	docs/UserGuide.md
@NaychiMin
Add relevant examples in PPP.
e76fc31
@NaychiMin NaychiMin added this to the v2.1 milestone Nov 12, 2023
ziyi105
ziyi105 approved these changes Nov 13, 2023
View reviewed changes
Copy link

@ziyi105 ziyi105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed explanations, good job!

DextheChik3n
DextheChik3n reviewed Nov 13, 2023
View reviewed changes
Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in your sequence diagrams that the classes are missing a colon ':' before the class name

@ziyi105 ziyi105 merged commit 237419d into AY2324S1-CS2113-T17-2:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DextheChik3n DextheChik3n DextheChik3n left review comments

@ziyi105 ziyi105 ziyi105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
3 participants
@NaychiMin @DextheChik3n @ziyi105