Finish all user stories for v2.0 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshiah
requested review from
ryan1604,
NeoMinWei,
wwweert123 and
YFshadaow
and removed request for
ryan1604 and
NeoMinWei
NeoMinWei
approved these changes
Nov 1, 2023
src/main/java/seedu/financialplanner/commands/MarkGoalCommand.java
Outdated
Show resolved
Hide resolved
| @@ -19,7 +23,7 @@ public UnmarkReminderCommand(RawCommand rawCommand) throws IllegalArgumentExcept | |||
| if (index == 0) { | |||
| throw new IllegalArgumentException("Index must be within the list"); | |||
| } | |||
| if (index > ReminderList.getInstance().list.size()+1){ | |||
| if (index > WishList.getInstance().list.size()+1){ | |||
There was a problem hiding this comment.
Suggested change
| if (index > WishList.getInstance().list.size()+1){ | |
| if (index > WishList.getInstance().list.size() + 1){ |
src/main/java/seedu/financialplanner/commands/MarkGoalCommand.java
Outdated
Show resolved
Hide resolved
| @@ -3,7 +3,7 @@ | |||
| import java.util.Arrays; | |||
|
|
|||
| public enum ExpenseType { | |||
| DINING, ENTERTAINMENT, SHOPPING, TRAVEL, INSURANCE, NECESSITIES, OTHERS; | |||
| DINING, ENTERTAINMENT, SHOPPING, TRAVEL, INSURANCE, NECESSITIES, OTHERS, GOAL; | |||
There was a problem hiding this comment.
can the goal be one of the expensetypes? ie. buy car would be under 'others'. so goal shouldnt be one of the types
…java Co-authored-by: Neo Min Wei <[email protected]>
…java Co-authored-by: Neo Min Wei <[email protected]>
ryan1604
approved these changes
Nov 1, 2023
src/main/java/seedu/financialplanner/commands/DeleteGoalCommand.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Can add functions to save and load goal and reminder from storage
There was a problem hiding this comment.
Sure, I will do it in v2.1 as enhancement.
…d.java Co-authored-by: ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish all user stories for v2.0