Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch final junit #194

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

NeoMinWei
Copy link

@NeoMinWei NeoMinWei commented Nov 6, 2023

fixes #153
fixes #154

@NeoMinWei NeoMinWei added this to the v2.1 milestone Nov 6, 2023
@NeoMinWei NeoMinWei self-assigned this Nov 6, 2023
Copy link

@ryan1604 ryan1604 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very extensive testing 👍

Copy link

@wwweert123 wwweert123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt really read but looks good!

} catch (IllegalArgumentException e) {
assertEquals("Unknown extra argument: x", e.getMessage());
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow upz

list
list income
list expense
list recurring

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice testing

@NeoMinWei NeoMinWei merged commit 878d782 into AY2324S1-CS2113-T18-2:master Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaDoc for Income/Expense Do JUnit for critical methods in Income/Expense
3 participants