Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG/DG #196

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

ryan1604
Copy link

@ryan1604 ryan1604 commented Nov 7, 2023

Fixes #145
Fixes #157
Fixes #167

@ryan1604 ryan1604 added this to the v2.1 milestone Nov 7, 2023
@ryan1604 ryan1604 self-assigned this Nov 7, 2023
Copy link

@NeoMinWei NeoMinWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage quite hard to see

{Give non-functional requirements}
* Should work on main OS (Windows, Linux, Mac) that has Java 11 installed.
* This app is meant for a single user.
* This app targeted towards users with an above-average typing speed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is targeted*

@@ -66,9 +66,9 @@ public String input() {
}

public void printWatchListHeader() {
showMessage("Symbol");
System.out.print(CYAN + "Symbol" + RESET);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -4,6 +4,7 @@

* [Acknowledgements](#acknowledgements)
* [Design & implementation](#design--implementation)
* [Architecture Diagram](#architecture-diagram)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice however the colours are a little too bright

* `Parser`: Parse user inputs.
* `Command`: The command executor.
* `Model`: Holds the data of the program in memory.
* `Storage`: Reads data from, and writes data to the hard disk.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add our important classes such as cashflowlist?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats all under model:)

* Implementation
* Sequence diagrams
* Non-functional requirements
* Architecture Diagram

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou!

@ryan1604 ryan1604 merged commit fba7732 into AY2324S1-CS2113-T18-2:master Nov 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants