-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UG/DG #196
Update UG/DG #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/images/ArchitectureDiagram.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
storage quite hard to see
docs/DeveloperGuide.md
Outdated
{Give non-functional requirements} | ||
* Should work on main OS (Windows, Linux, Mac) that has Java 11 installed. | ||
* This app is meant for a single user. | ||
* This app targeted towards users with an above-average typing speed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is targeted*
@@ -66,9 +66,9 @@ public String input() { | |||
} | |||
|
|||
public void printWatchListHeader() { | |||
showMessage("Symbol"); | |||
System.out.print(CYAN + "Symbol" + RESET); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -4,6 +4,7 @@ | |||
|
|||
* [Acknowledgements](#acknowledgements) | |||
* [Design & implementation](#design--implementation) | |||
* [Architecture Diagram](#architecture-diagram) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice however the colours are a little too bright
* `Parser`: Parse user inputs. | ||
* `Command`: The command executor. | ||
* `Model`: Holds the data of the program in memory. | ||
* `Storage`: Reads data from, and writes data to the hard disk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add our important classes such as cashflowlist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats all under model:)
* Implementation | ||
* Sequence diagrams | ||
* Non-functional requirements | ||
* Architecture Diagram |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou!
Fixes #145
Fixes #157
Fixes #167