Skip to content

Commit

Permalink
Make minor chagnes
Browse files Browse the repository at this point in the history
Make changes in the output value of Faculty in some splaces of the codes as the type is now Enum.
  • Loading branch information
JerryWang0000 committed Mar 15, 2024
1 parent 7b6d4ab commit cea9d93
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/main/java/staffconnect/storage/JsonAdaptedPerson.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public JsonAdaptedPerson(Person source) {
name = source.getName().fullName;
phone = source.getPhone().value;
email = source.getEmail().value;
faculty = source.getFaculty().value;
faculty = source.getFaculty().toString();
venue = source.getVenue().value;
module = source.getModule().value;
tags.addAll(source.getTags().stream()
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/staffconnect/ui/PersonCard.java
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public PersonCard(Person person, int displayedIndex) {
id.setText(displayedIndex + ". ");
name.setText(person.getName().fullName);
phone.setText(person.getPhone().value);
faculty.setText(person.getFaculty().value);
faculty.setText(person.getFaculty().toString());

Check warning on line 57 in src/main/java/staffconnect/ui/PersonCard.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/staffconnect/ui/PersonCard.java#L57

Added line #L57 was not covered by tests
venue.setText(person.getVenue().value);
module.setText(person.getModule().value);

Check warning on line 59 in src/main/java/staffconnect/ui/PersonCard.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/staffconnect/ui/PersonCard.java#L59

Added line #L59 was not covered by tests
email.setText(person.getEmail().value);
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/staffconnect/testutil/PersonUtil.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static String getPersonDetails(Person person) {
sb.append(PREFIX_NAME + person.getName().fullName + " ");
sb.append(PREFIX_PHONE + person.getPhone().value + " ");
sb.append(PREFIX_EMAIL + person.getEmail().value + " ");
sb.append(PREFIX_FACULTY + person.getFaculty().value + " ");
sb.append(PREFIX_FACULTY + person.getFaculty().toString() + " ");
sb.append(PREFIX_VENUE + person.getVenue().value + " ");
sb.append(PREFIX_MODULE + person.getModule().value + " ");
person.getTags().stream().forEach(
Expand Down

0 comments on commit cea9d93

Please sign in to comment.