Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for clarity for testers #244

Conversation

whitesnowx
Copy link
Collaborator

@whitesnowx whitesnowx commented Apr 12, 2024

Provide clarify on our accepted values and allowance for adding contacts


Additionally:

  • Specifies MODULE, FACULTY, VENUE unique/duplicate restrictions
  • Specifies TAG and AVAILABILITY unique/duplicate restrictions
  • Removes Redundant [Attribute] in help message
  • Known issues for exit via button does not generate json file (if not manipulated) but exit via command is workaround
  • Replace contacts to staff book or persons where relevant to improve clarity.

@whitesnowx whitesnowx closed this Apr 12, 2024
@whitesnowx whitesnowx self-assigned this Apr 13, 2024
@whitesnowx whitesnowx added the type.Documentation Improvements or additions to documentation label Apr 13, 2024
@whitesnowx whitesnowx added this to the v1.4 milestone Apr 13, 2024
@whitesnowx whitesnowx reopened this Apr 13, 2024
@whitesnowx whitesnowx linked an issue Apr 13, 2024 that may be closed by this pull request
@whitesnowx whitesnowx closed this Apr 13, 2024
@whitesnowx whitesnowx reopened this Apr 13, 2024
@whitesnowx whitesnowx closed this Apr 13, 2024
@whitesnowx whitesnowx reopened this Apr 13, 2024
@whitesnowx whitesnowx added the type.Task Something that needs to be done, but not a story, bug, or an epic. label Apr 13, 2024
@iynixil
Copy link
Collaborator

iynixil commented Apr 13, 2024

clarification: need to standardize whether to use person, contacts, staff book

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (e1d79ba) to head (5aff9ba).
Report is 54 commits behind head on master.

❗ Current head 5aff9ba differs from pull request most recent head 45f3d52. Consider uploading reports for the commit 45f3d52 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #244   +/-   ##
=========================================
  Coverage     78.55%   78.55%           
  Complexity      846      846           
=========================================
  Files           121      121           
  Lines          2583     2583           
  Branches        262      262           
=========================================
  Hits           2029     2029           
  Misses          498      498           
  Partials         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iynixil iynixil merged commit 72a43af into AY2324S2-CS2103-F08-3:master Apr 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation Improvements or additions to documentation type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document for Clarity addressing bug reports
2 participants