Update SortActivityDiagram and Reorganise Implementations in DeveloperGuide #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitesnowx
added
the
type.Documentation
iynixil
reviewed
Apr 13, 2024
docs/DeveloperGuide.md
Outdated
|
|
||
| Need for `MultiComparator` object: | ||
| This is to map the 1 or more comparator objects and act as a layer of abstraction where `SortCommmand` does need to know how many attributes are used in sorting. | ||
| This also w |
There was a problem hiding this comment.
clarification: incomplete sentence?
docs/DeveloperGuide.md
Outdated
| **Aspect: Determining order of sorting of an attribute:** | ||
|
|
||
| * **Current Design:** Get order of sorting from user, prompting for an input in the form of toCompare. | ||
| * **Current Design:** Get order of attributes sorting from user input. |
There was a problem hiding this comment.
suggestion: Get order of attributes sorting -> Get sorting order of attributes may be clearer?
|
Noticed that you reordered that statements, as I was gonna do it too. But you can choose to merge this first, then I will make #249 follow your layout when dealing with the conflicts |
iynixil
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actions:
while()and appropriate notations to match CS2103 UML standards inSortActivityDiagram.pumlDeveloperGude.mdto matchUserGuide.mdWhy sort is implemented this way🖊️ 🐧