Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fav/unfav feature to be more specific in developer guide #268

Merged
merged 19 commits into from
Apr 15, 2024
Merged

Update fav/unfav feature to be more specific in developer guide #268

merged 19 commits into from
Apr 15, 2024

Conversation

tsulim
Copy link
Collaborator

@tsulim tsulim commented Apr 14, 2024

Closes #263

@tsulim tsulim added the type.Documentation Improvements or additions to documentation label Apr 14, 2024
@tsulim tsulim added this to the v1.4 milestone Apr 14, 2024
@tsulim tsulim self-assigned this Apr 14, 2024
@tsulim tsulim marked this pull request as ready for review April 14, 2024 20:55
@Pluiexo Pluiexo mentioned this pull request Apr 15, 2024
Merged
iynixil
iynixil reviewed Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@iynixil iynixil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some clarifications and nits
note: remember to update PNGs after the changes have been made 🦺

docs/diagrams/FavActivityDiagram.puml Outdated Show resolved Hide resolved
docs/diagrams/FavRefSequenceDiagram.puml Outdated Show resolved Hide resolved
docs/diagrams/UnfavActivityDiagram.puml Outdated Show resolved Hide resolved
docs/diagrams/UnfavRefSequenceDiagram.puml Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Show resolved Hide resolved
@iynixil iynixil merged commit 057c4b9 into AY2324S2-CS2103-F08-3:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iynixil iynixil iynixil approved these changes

Assignees

@tsulim tsulim

Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Update fav/unfav feature in developer guide
2 participants
@tsulim @iynixil