Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize diagrams in developer guide #271

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Resize diagrams in developer guide #271

merged 2 commits into from
Apr 15, 2024

Conversation

tsulim
Copy link
Collaborator

@tsulim tsulim commented Apr 14, 2024 •
edited
Loading

#270

  • The text size in the diagram matches the text size of the main text of the diagram.
  • Max width of image is 740px

Important

Required to check if there's a need to resize diagrams again after the other pull requests have been merged.

@tsulim tsulim added the type.Documentation Improvements or additions to documentation label Apr 14, 2024
@tsulim tsulim added this to the v1.4 milestone Apr 14, 2024
@tsulim tsulim self-assigned this Apr 14, 2024
@whitesnowx whitesnowx marked this pull request as ready for review April 15, 2024 11:20
JerryWang0000
JerryWang0000 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@JerryWang0000 JerryWang0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JerryWang0000 JerryWang0000 merged commit 294c300 into AY2324S2-CS2103-F08-3:master Apr 15, 2024
3 checks passed
whitesnowx
whitesnowx reviewed Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@whitesnowx whitesnowx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitesnowx whitesnowx whitesnowx left review comments

@iynixil iynixil iynixil approved these changes

@JerryWang0000 JerryWang0000 JerryWang0000 approved these changes

Assignees

@tsulim tsulim

Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@tsulim @whitesnowx @JerryWang0000 @iynixil