Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update aboutus page #33

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Update aboutus page #33

merged 2 commits into from
Mar 6, 2024

Conversation

tsulim
Copy link
Collaborator

@tsulim tsulim commented Mar 6, 2024

  • Add my details and photo
  • Update file name to follow format

@tsulim tsulim added the type.Documentation Improvements or additions to documentation label Mar 6, 2024
@tsulim tsulim added this to the v1.1 milestone Mar 6, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (8704937) to head (36404ac).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whitesnowx
whitesnowx approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@whitesnowx whitesnowx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ദ്ദി ˉ͈̀꒳ˉ͈́ )✧

JerryWang0000
JerryWang0000 reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@JerryWang0000 JerryWang0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. At least I don't find anything that needs editing. Thx for changing my pic to png format.

@whitesnowx whitesnowx merged commit d2d9470 into AY2324S2-CS2103-F08-3:master Mar 6, 2024
5 checks passed
@tsulim tsulim linked an issue Mar 6, 2024 that may be closed by this pull request
Update AboutUs page #20
Closed
5 tasks
@tsulim tsulim deleted the branch_update_aboutus branch March 7, 2024 19:06
@tsulim tsulim self-assigned this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JerryWang0000 JerryWang0000 JerryWang0000 left review comments

@whitesnowx whitesnowx whitesnowx approved these changes

Assignees

@tsulim tsulim

Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Update AboutUs page
3 participants
@tsulim @whitesnowx @JerryWang0000