Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages from seedu.address to staffconnect #54

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

tsulim
Copy link
Collaborator

@tsulim tsulim commented Mar 9, 2024

  • Refactor package seedu.address to staffconnect in main
  • Refactor package seedu.address to staffconnect in test
  • Update remaining files with traces of seedu.address in test
  • Update files with traces of the package name seedu.address to staffconnect

@tsulim tsulim added the type.Task Something that needs to be done, but not a story, bug, or an epic. label Mar 9, 2024
@tsulim tsulim added this to the v1.2 milestone Mar 9, 2024
@tsulim tsulim self-assigned this Mar 9, 2024
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (1c6ff30) to head (742016c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage     75.26%   75.26%           
  Complexity      419      419           
=========================================
  Files            71       71           
  Lines          1338     1338           
  Branches        126      126           
=========================================
  Hits           1007     1007           
  Misses          301      301           
  Partials         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Pluiexo Pluiexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far! Though I have a point to bring up.

Should the files like AddressBook under model and parser package be renamed as well to better fit the consistency of our product? Would like inputs from others as well to consider if we should make this changes optional if it is too much redundant work

@tsulim
Copy link
Collaborator Author

tsulim commented Mar 10, 2024

@Pluiexo Yes, I agree that those should be renamed. However, the title of this pull request is to rename packages name, so those changes will be in a separate pull request made later on.

Copy link

@Pluiexo Pluiexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then!!

@Pluiexo Pluiexo merged commit 0e15fa1 into AY2324S2-CS2103-F08-3:master Mar 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename packages from seedu.address to staffconnect Remove traces of AB3 in the code
2 participants