-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename packages from seedu.address
to staffconnect
#54
Rename packages from seedu.address
to staffconnect
#54
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
=========================================
Coverage 75.26% 75.26%
Complexity 419 419
=========================================
Files 71 71
Lines 1338 1338
Branches 126 126
=========================================
Hits 1007 1007
Misses 301 301
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far! Though I have a point to bring up.
Should the files like AddressBook under model and parser package be renamed as well to better fit the consistency of our product? Would like inputs from others as well to consider if we should make this changes optional if it is too much redundant work
@Pluiexo Yes, I agree that those should be renamed. However, the title of this pull request is to rename packages name, so those changes will be in a separate pull request made later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright then!!
seedu.address
tostaffconnect
inmain
seedu.address
tostaffconnect
intest
seedu.address
intest
seedu.address
tostaffconnect