Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter functionality for tags #67

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

iynixil
Copy link
Collaborator

@iynixil iynixil commented Mar 13, 2024

Added filter functionality for tags - can handle single or multiple
Added temporary comments in the files to be used later when implementing filter by module/faculty.

@iynixil iynixil added type.Task Something that needs to be done, but not a story, bug, or an epic. priority.High Must do labels Mar 13, 2024
@iynixil iynixil added this to the v1.2 milestone Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (2a635ab) to head (0d981b7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
+ Coverage     75.36%   76.12%   +0.75%     
- Complexity      424      444      +20     
============================================
  Files            72       75       +3     
  Lines          1352     1395      +43     
  Branches        127      130       +3     
============================================
+ Hits           1019     1062      +43     
  Misses          303      303              
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iynixil iynixil force-pushed the 49-filter-contacts branch from 3a6c45c to 68f35d1 Compare March 13, 2024 08:29
@iynixil iynixil changed the title Add filter functionality for a single tag Add filter functionality for tags Mar 13, 2024
whitesnowx

This comment was marked as duplicate.

Copy link
Collaborator

@whitesnowx whitesnowx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ✨

@whitesnowx whitesnowx merged commit 6874f37 into AY2324S2-CS2103-F08-3:master Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants