Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to use Module attribute #69

Merged
merged 33 commits into from
Mar 14, 2024

Conversation

tsulim
Copy link
Collaborator

@tsulim tsulim commented Mar 13, 2024

Closes #9, closes #48

  • Add Module data field to Person model
  • Update commands (e.g., add and edit) to use Module
  • Add sample Module data to SampleDataUtil
  • Update tests to cover Module
  • Update test data with sample Module data
  • Update ui to display Module in the application

tsulim added 30 commits March 12, 2024 20:58
@tsulim tsulim added the type.Task Something that needs to be done, but not a story, bug, or an epic. label Mar 13, 2024
@tsulim tsulim added this to the v1.2 milestone Mar 13, 2024
@tsulim tsulim self-assigned this Mar 13, 2024
@tsulim tsulim added the priority.High Must do label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 76.20%. Comparing base (50d5a04) to head (6c4cc36).
Report is 1 commits behind head on master.

Files Patch % Lines
...n/java/staffconnect/model/util/SampleDataUtil.java 0.00% 6 Missing ⚠️
...rc/main/java/staffconnect/model/person/Person.java 85.71% 1 Missing ⚠️
src/main/java/staffconnect/ui/PersonCard.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
+ Coverage     75.70%   76.20%   +0.50%     
- Complexity      436      444       +8     
============================================
  Files            73       73              
  Lines          1379     1408      +29     
  Branches        133      139       +6     
============================================
+ Hits           1044     1073      +29     
  Misses          305      305              
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@iynixil iynixil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made a suggestion for Module values.

src/test/java/staffconnect/model/person/ModuleTest.java Outdated Show resolved Hide resolved
@iynixil iynixil merged commit 618b8b8 into AY2324S2-CS2103-F08-3:master Mar 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
3 participants