-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to use Module
attribute
#69
Update code to use Module
attribute
#69
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
============================================
+ Coverage 75.70% 76.20% +0.50%
- Complexity 436 444 +8
============================================
Files 73 73
Lines 1379 1408 +29
Branches 133 139 +6
============================================
+ Hits 1044 1073 +29
Misses 305 305
Partials 30 30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Made a suggestion for Module values.
Closes #9, closes #48
Module
data field toPerson
modeladd
andedit
) to useModule
Module
data toSampleDataUtil
Module
Module
dataModule
in the application