Add Meeting class and the corresponding test #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #74 +/- ##
============================================
+ Coverage 76.20% 77.45% +1.25%
- Complexity 444 487 +43
============================================
Files 73 79 +6
Lines 1408 1495 +87
Branches 139 146 +7
============================================
+ Hits 1073 1158 +85
- Misses 305 307 +2
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Pluiexo
force-pushed
the
branch-Meeting-Attribute
branch
from
a39ea0f to
4f80e1e
Compare
tsulim
reviewed
Mar 15, 2024
Comment on lines
27
to
30
| // null Date | ||
| assertThrows(NullPointerException.class, () -> MeetDateTime.isValidMeetDateTime(null)); | ||
|
|
||
| // invalid Meeting Date code |
There was a problem hiding this comment.
Perhaps you could standardize the comments?
| assertFalse(MeetDateTime.isValidMeetDateTime("12/4/2023 12:00")); // wrong number digits for month | ||
| assertFalse(MeetDateTime.isValidMeetDateTime("1/04/2023 12:00")); // wrong number digits for day | ||
|
|
||
| // valid module code |
There was a problem hiding this comment.
I think you missed out this one too.
Comment on lines
16
to
43
| @Test | ||
| public void constructor_null_throwsNullPointerException() { | ||
| assertThrows(NullPointerException.class, () -> new Name(null)); | ||
| } | ||
|
|
||
| @Test | ||
| public void constructor_invalidName_throwsIllegalArgumentException() { | ||
| String invalidDescription = ""; | ||
| assertThrows(IllegalArgumentException.class, () -> new Name(invalidDescription)); | ||
| } | ||
|
|
||
| @Test | ||
| public void isValidDescription() { | ||
| // null name | ||
| assertThrows(NullPointerException.class, () -> Description.isValidDescription(null)); | ||
|
|
||
| // invalid name | ||
| assertFalse(Name.isValidName("")); // empty string | ||
| assertFalse(Name.isValidName(" ")); // spaces only | ||
| assertFalse(Name.isValidName("^")); // only non-alphanumeric characters | ||
| assertFalse(Name.isValidName("peter meeting*")); // contains non-alphanumeric characters | ||
|
|
||
| // valid name | ||
| assertTrue(Name.isValidName("meeting")); // alphabets only | ||
| assertTrue(Name.isValidName("12345")); // numbers only | ||
| assertTrue(Name.isValidName("meeting at for 2nd finals")); // alphanumeric characters | ||
| assertTrue(Name.isValidName("Crush the exam")); // with capital letters | ||
| assertTrue(Name.isValidName("Super hard midterm with finals and project combined 2nd")); // long names |
There was a problem hiding this comment.
Perhaps it is Description instead of Name?
iynixil
reviewed
Mar 15, 2024
Thanks has been fixed, I did this in the morning, so quite a number of errors missed out :( |
Pluiexo
force-pushed
the
branch-Meeting-Attribute
branch
from
3990e05 to
01ee036
Compare
tsulim
added
the
type.Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commands to manipulate meeting will be in the next pull request. Closes #43