Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to use Faculty attribute #75

Merged
merged 58 commits into from
Mar 16, 2024

Conversation

JerryWang0000
Copy link
Collaborator

@JerryWang0000 JerryWang0000 commented Mar 15, 2024

The attribute is now restricted to typing in exactly the same string as the name of the faculty.

Closes #51

JerryWang0000 and others added 28 commits March 14, 2024 00:37
Represent faculty by "f/"
Make minor changes to EditPersonDescriptorBuilder.java
Debug some parts in the test classes.
@JerryWang0000 JerryWang0000 added type.Task Something that needs to be done, but not a story, bug, or an epic. severity.High A flaw that affects most users and causes major problems for users. Almost unusable for most users. labels Mar 15, 2024
@JerryWang0000
Copy link
Collaborator Author

Need to change some codes cause now the value stored in Faculty is Enum

Make changes in the output value of Faculty in some splaces of the codes as the type is now Enum.
Copy link
Collaborator

@whitesnowx whitesnowx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@whitesnowx whitesnowx merged commit 4c0e50a into AY2324S2-CS2103-F08-3:master Mar 16, 2024
5 checks passed
@tsulim tsulim linked an issue Apr 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code to use the Faculty attribute As a forgetful user, I can store a professor's faculty
3 participants