forked from nus-cs2103-AY2324S2/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to use Faculty
attribute
#75
Merged
whitesnowx
merged 58 commits into
AY2324S2-CS2103-F08-3:master
from
JerryWang0000:use-Faculty
Mar 16, 2024
Merged
Update code to use Faculty
attribute
#75
whitesnowx
merged 58 commits into
AY2324S2-CS2103-F08-3:master
from
JerryWang0000:use-Faculty
Mar 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Represent faculty by "f/"
…der to include Faculty
Make minor changes to EditPersonDescriptorBuilder.java
Debug some parts in the test classes.
JerryWang0000
added
type.Task
Something that needs to be done, but not a story, bug, or an epic.
severity.High
A flaw that affects most users and causes major problems for users. Almost unusable for most users.
labels
Mar 15, 2024
…der to include Faculty
Make minor changes to EditPersonDescriptorBuilder.java
Debug some parts in the test classes.
Need to change some codes cause now the value stored in |
Make changes in the output value of Faculty in some splaces of the codes as the type is now Enum.
whitesnowx
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute is now restricted to typing in exactly the same string as the name of the faculty.
Closes #51