Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ModelClassDiagram to include Faculty #78

Merged

Conversation

JerryWang0000
Copy link
Collaborator

@JerryWang0000 JerryWang0000 commented Mar 15, 2024

Closes #76

@JerryWang0000 JerryWang0000 added the type.Documentation Improvements or additions to documentation label Mar 15, 2024
@JerryWang0000 JerryWang0000 added this to the v1.2 milestone Mar 15, 2024
@JerryWang0000
Copy link
Collaborator Author

Merge Faculty Class First

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.25%. Comparing base (e1b7be0) to head (347140c).
Report is 127 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
+ Coverage     77.81%   78.25%   +0.43%     
- Complexity      495      503       +8     
============================================
  Files            80       80              
  Lines          1537     1568      +31     
  Branches        148      154       +6     
============================================
+ Hits           1196     1227      +31     
  Misses          310      310              
  Partials         31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pluiexo Pluiexo reopened this Mar 15, 2024
@JerryWang0000 JerryWang0000 linked an issue Mar 15, 2024 that may be closed by this pull request
Copy link
Collaborator

@tsulim tsulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tsulim tsulim merged commit e22c1e3 into AY2324S2-CS2103-F08-3:master Mar 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Faculty to ModelClassDiagram
4 participants