-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user guide on the usage of Availability
#82
Update user guide on the usage of Availability
#82
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
============================================
+ Coverage 77.29% 78.33% +1.03%
- Complexity 472 529 +57
============================================
Files 77 86 +9
Lines 1493 1620 +127
Branches 144 159 +15
============================================
+ Hits 1154 1269 +115
- Misses 308 320 +12
Partials 31 31 ☔ View full report in Codecov by Sentry. |
|
||
* Edits the person at the specified `INDEX`. The index refers to the index number shown in the displayed person list. The index **must be a positive integer** 1, 2, 3, … | ||
* At least one of the optional fields must be provided. | ||
* Existing values will be updated to the input values. | ||
* When editing tags, the existing tags of the person will be removed i.e adding of tags is not cumulative. | ||
* You can remove all the person’s tags by typing `t/` without | ||
specifying any tags after it. | ||
* When editing availabilities, the existing availabilites of the person will be removed i.e adding of availabilities is not cumulative. | ||
* You can remove all the person’s availabilities by typing `a/` without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to link the same issue in #80 , would the empty list indicate availability for all days of the week?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just the same issue questioned in the implementation PR
amend example to include availability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOOK GOOD TO ME 🤸♂️
/APPROVE
Closes #81
Segments to edit:
add
edit
add
andedit