Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Find command to search using Person's IC #46

Merged

Conversation

jiahui0309
Copy link

Added support for usage of find command (Closes #10). This PR covers:

  • New Class (IdentityCardNumberMatchesPredicate) to support searching of IC in FindCommand Class.
  • Ensuring that the parsing of arguments with the command word find is updated with the new class.
  • Updating Unit tests to ensure that FindCommand runs and throws errors where necessary.
  • The program can compile and run without a problem.

If one of these points above still has an issue please let me know. The FindCommand Class now looks like this:
Screenshot 2024-03-16 at 2 43 48 PM

Note:

  • The command has yet to be tried on the actual interface as the AddCommand has to be updated first.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.09%. Comparing base (dfcbf36) to head (53dac0a).

Files Patch % Lines
.../seedu/address/logic/parser/FindCommandParser.java 40.00% 3 Missing ⚠️
...del/person/IdentityCardNumberMatchesPredicate.java 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     73.08%   73.09%           
- Complexity      453      460    +7     
=========================================
  Files            75       76    +1     
  Lines          1464     1483   +19     
  Branches        145      147    +2     
=========================================
+ Hits           1070     1084   +14     
- Misses          352      356    +4     
- Partials         42       43    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@tengcharmaine tengcharmaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiahui0309 jiahui0309 merged commit 14de819 into AY2324S2-CS2103T-F14-2:master Mar 16, 2024
5 checks passed
@drustanyjt drustanyjt added this to the v1.2 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user I can search for specific patients
3 participants