Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs raised in PE-D #134

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

sun-ruiheng
Copy link

Fixed the bugs explicitly assigned to me so far.

Might add more commits for further bugs.

@sun-ruiheng
Copy link
Author

Sorry for laziness earlier and not specifying the issues I targeted, but it's all the issues assigned to me that have been resolved. You can filter the issue list and get a comprehensive view

@@ -2,22 +2,22 @@

import static seedu.address.logic.parser.ParserUtil.parseNoArgs;

import seedu.address.logic.commands.ShowFavouriteCommand;
import seedu.address.logic.commands.ListFavouriteCommand;
import seedu.address.logic.parser.exceptions.ParseException;

/**
* Parses input arguments and creates a new ShowFavouriteCommand object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation not changed to new commands yet

Copy link

@gavingoh99 gavingoh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you update the DG to reflect List favourite feature instead of Show favourite feature

Referring to this part:
Screenshot 2024-04-12 at 12 03 45 AM

Copy link

@gavingoh99 gavingoh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the documentation changes!

@sun-ruiheng sun-ruiheng merged commit 27bb541 into AY2324S2-CS2103T-T16-3:master Apr 11, 2024
@sun-ruiheng sun-ruiheng deleted the Bug-Fixes-1.4 branch April 11, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants